Added: option to show tab subtitle with URL#1924
Open
emvaized wants to merge 2 commits into
Open
Conversation
Contributor
|
I feel that this feature is more closely related to the "Show URL in tooltip" option and should be placed before or after it. |
Contributor
Author
Wouldn't this option then be misinterpreted as related to the tooltip? |
Contributor
|
I don't think so... Is the text of the two options hard to understand? Especially when they are already two different settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an option to show subtitle below each tab with its URL. It probably wasn't requested by anyone, but I suddenly came up with this idea, and after test-driving it for a few days I quite liked it. Seeing all urls at once allows to navigate tabs quicker, and makes it easier to distinguish between them.
By default this option is disabled, and should be manually discovered and enabled in Sidebery settings > Tabs. Subtitle shows url of each tab, but in the future it could possibly be used to show any other information. "https://" part of the URL is trimmed in the beginning, because I found it visually overwhelming (I'm not sure if "http://" should be trimmed as well).
This PR also adds some basic styles for the subtitle, such as smaller font and 70% opacity. It could probably also include some rules to increase default tab height when subtitles are enabled, but it currently doesn't do that, so tabs might become a bit too crowded with the default tab height.
Here's how it looks with
--tabs-height=40pxset in the styles editor (recommended):